Fix config save failure when Impl assembly is loaded from memory#32
Merged
AgentSmithers merged 1 commit intoMay 24, 2026
Merged
Conversation
McpServerConfig.ConfigPath previously relied on Assembly.Location In debug / unloadable mode, the Impl assembly may be loaded from memory This can make Assembly.Location empty and cause The path is not of a legal form. Fix by falling back to AppDomain.CurrentDomain.BaseDirectory and then Environment.CurrentDirectory
Owner
|
Merged. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
McpServerConfig previously relied on Assembly.Location to build the
config file path. In debug/unloadable mode, the Impl assembly may be
loaded from memory, which can leave Assembly.Location empty and cause
"The path is not of a legal form." when saving config.
Fall back to AppDomain.CurrentDomain.BaseDirectory and then
Environment.CurrentDirectory when the assembly path is unavailable.